fix(Android): make flakiest tests more robust #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: Fix flaky android emulator tests
I went through the 25 most recent CI failures, ignored the ones where other CI steps failed or the failing emulator tests looked related to the changes made in the PR, and added a
waitUntilto give the non-Compose mocked network requests a little more time to settle. (I also added some scrolling on the one test here that was failing in Compose assertions, on the assumption that it's a scrolling issue again.)iOS
[ ] If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?[ ] Add temporary machine translations, marked "Needs Review"android
[ ] All user-facing strings added to strings resource[ ] Expensive calculations are run inwithContext(Dispatchers.Default)where possibleTesting
Ran the tests locally and checked that they all pass, although that only guarantees that I didn't break any of these tests, not that they'll pass more often in CI now.