feat: analytics on Android #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boringcactus
commented
Jan 17, 2025
androidApp/src/main/java/com/mbta/tid/mbta_app/android/MainApplication.kt
Outdated
Show resolved
Hide resolved
| @@ -162,13 +162,6 @@ abstract class Analytics { | |||
| ) | |||
| } | |||
|
|
|||
| fun toggledPinnedRouteAtStop(pinned: Boolean, routeId: String) { | |||
There was a problem hiding this comment.
This turned out to be redundant with the togglePinnedRoute that precedes it; we needed different names so the extensions didn't collide, but since we aren't defining each page's analytics as a separate extension on the AnalyticsProvider anymore, we do not need two equivalent versions of methods like this. I didn't need to make this part of this PR, but it felt like it wasn't worth spinning out into a separate PR.
BrandonTR
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: GA for Android
I think this means I did a good job of designing the shared elements in #658.
iOS
[ ] If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?[ ] Add temporary machine translations, marked "Needs Review"android
[ ] All user-facing strings added to strings resource[ ] Expensive calculations are run inwithContext(Dispatchers.Default)where possibleTesting
Verified with Firebase Analytics Debug View that all the events are being sent correctly.