feat(Android): Stop details headers #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements the header UI for both filtered and unfiltered stop details. There are currently some awkward layout issues that will become irrelevant with other necessary fixes and refactors: * When loading filtered stop details, the unfiltered header is always shown instead of the filtered header, this will be resolved when we do a more involved refactor to split them into separate views higher up. * Loading placeholders aren't displayed for either header. * The stop sheet header isn't set to fill2/surfaceContainer because that interacts poorly with page transitions, the entire sheet background needs to be set in order to get behind the drag handle, but it wasn't transitioning between the two colors well.
BrandonTR
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: 🤖 | stop + trip details | navigation buttons
This implements the header UI for both filtered and unfiltered stop
details.
There are currently some awkward layout issues that will become
irrelevant with other necessary fixes and refactors:
shown instead of the filtered header, this will be resolved when we do
a more involved refactor to split them into separate views higher up.
interacts poorly with page transitions, the entire sheet background
needs to be set in order to get behind the drag handle, but it wasn't
transitioning between the two colors well.
android
- [ ] Expensive calculations are run inwithContext(Dispatchers.Default)where possibleTesting
Manual testing, unit tests