feat(iOS): elevator alert UI #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaylaBrady
approved these changes
Jan 31, 2025
| } | ||
| alertDescription | ||
| if isElevatorClosure { | ||
| alertPeriod |
There was a problem hiding this comment.
The alert period is a bit squished. I see this also is an issue for other alerts. If minor, could you include the fix here?
There was a problem hiding this comment.
I did wonder when I implemented this on Android why the structure was the way that it was on iOS. This seems better:
i wish very much that Apple hadn't randomly broken Xcode 15 on macOS Sequoia
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: | elevator alerts UI
This was not as straightforward as I had expected.
In alert details, the designs call for showing the elevator facility info, but we don't have that. The one currently available elevator closure alert has the facility info and cause in the description, though, so it seems like showing that may be close enough for now.
Some of the provisional translations of "N elevators closed" are the same as the old provisional translations of "N elevator closures" - I'm not sure if those languages really don't have that distinction or if our provisional translations are just not all that great.
iOS
android
[ ] All user-facing strings added to strings resource in alphabetical order[ ] Expensive calculations are run inwithContext(Dispatchers.Default)where possibleTesting
Manually verified that things work in roughly the way they're supposed to. Added and updated unit tests.