feat(StopLayerGenerator): Preserve selected stop label across zoom levels #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boringcactus
reviewed
Feb 6, 2025
| stopSelectedPinLayer.textJustify = TextJustify.AUTO | ||
| stopSelectedPinLayer.textAllowOverlap = true | ||
| stopSelectedPinLayer.textOptional = true | ||
| stopSelectedPinLayer.textOffset = MapExp.labelOffsetExp |
There was a problem hiding this comment.
Should this be a call to includeDefaultTextProps?
KaylaBrady
force-pushed
the
kb-selected-stop-label
branch
from
528009d to
d08b2b7
Compare
boringcactus
approved these changes
Feb 6, 2025
JackVCurtis
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: | respond to Combined Stop + Trip QA feedback
What is this PR for?
Small follow-up to #707 so that the selected stop label is shown at all zoom levels where stops are shown.
iOS
android
withContext(Dispatchers.Default)where possibleTesting
What testing have you done?