feat(iOS): Combined stop + trip promo UX #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boringcactus
approved these changes
Feb 5, 2025
| @@ -140,7 +140,7 @@ | |||
| <string name="police_action">Police Action</string> | |||
| <string name="police_activity">Police Activity</string> | |||
| <string name="power_problem">Power Problem</string> | |||
| <string name="predictions_unavailable_details">Service is running, but predicted arrival times aren’t available. The map shows where %1$s on this route currently are.</string> | |||
| <string name="predictions_unavailable_details">Service is running, but predicted arrival times aren’t available. Check the map to see where %1$s are right now.</string> | |||
There was a problem hiding this comment.
Probably worth running the Android build to update the Android translations so they aren't stale in-tree.
There was a problem hiding this comment.
I didn't actually bother updating the translations for this, since we're just about to send out the strings to get translated, and it's a relatively minor copy change on text that won't be released until after we get back official translations.
shared/src/commonMain/kotlin/com/mbta/tid/mbta_app/model/FeaturePromo.kt
Outdated
Show resolved
Hide resolved
EmmaSimon
force-pushed
the
es-combined-stop-promo-page
branch
from
edb0f2b to
83c058b
Compare
EmmaSimon
force-pushed
the
es-combined-stop-promo-page
branch
from
83c058b to
a5ab10e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: | Combined Stop + Trip Details: Launch promo
Adds the UX for the combined stop + trip promo page. We don't have a finalized graphic yet, so that's left as a todo, and it's only set to show up once we update the version number to 1.2.0, so currently you can only make it show up by manually updating the version locally.
iOS
Testing
Added some basic UI tests