fix(iOS): Make map padding uniform #717
Merged
Xcode Cloud / MBTA Transit Staging | PR Branch Workflow | iosAppRetries - iOS
succeeded
Feb 7, 2025 in 26m 39s
70 warnings
| Report Summary | |
|---|---|
| Errors | 0 |
| Test Failures | 0 |
| Analysis Issues | 0 |
| Warnings | 70 |
Details
70 Warnings
Details
iosApp/iosApp/Pages/StopDetails/TripHeaderCard.swift:149
Line Length Violation: Line should be 120 characters or less; currently it has 137 characters (line_length)
Todo Violation: TODOs should be resolved (Add all possible alert effects...) (todo)
Line Length Violation: Line should be 120 characters or less; currently it has 125 characters (line_length)
Line Length Violation: Line should be 120 characters or less; currently it has 137 characters (line_length)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
Immutable value 'tripFilter' was never used; consider replacing with '_' or removing it
Line Length Violation: Line should be 120 characters or less; currently it has 123 characters (line_length)
Initialization of immutable value 'springboard' was never used; consider replacing with assignment to '_' or removing it
Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
Instance method 'wait' is unavailable from asynchronous contexts; Use await fulfillment(of:timeout:enforceOrder:) instead; this is an error in Swift 6
Line Length Violation: Line should be 120 characters or less; currently it has 175 characters (line_length)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Line Length Violation: Line should be 120 characters or less; currently it has 139 characters (line_length)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Unused Optional Binding Violation: Prefer `!= nil` over `let _ =` (unused_optional_binding)
Redundant Optional Initialization Violation: Initializing an optional variable with nil is redundant (redundant_optional_initialization)
Default will never be executed
Initialization of immutable value 'mapVM' was never used; consider replacing with assignment to '_' or removing it
Redundant Optional Initialization Violation: Initializing an optional variable with nil is redundant (redundant_optional_initialization)
File Length Violation: File should contain 400 lines or less: currently contains 502 (file_length)
Immutable value 'error' was never used; consider replacing with '_' or removing it
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Line Length Violation: Line should be 120 characters or less; currently it has 180 characters (line_length)
Line Length Violation: Line should be 120 characters or less; currently it has 131 characters (line_length)
Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 308 lines (type_body_length)
Line Length Violation: Line should be 120 characters or less; currently it has 137 characters (line_length)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Line Length Violation: Line should be 120 characters or less; currently it has 128 characters (line_length)
Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 318 lines (type_body_length)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Immutable value 'error' was never used; consider replacing with '_' or removing it
Line Length Violation: Line should be 120 characters or less; currently it has 125 characters (line_length)
Line Length Violation: Line should be 120 characters or less; currently it has 123 characters (line_length)
'MapContentGestureContext' is deprecated: renamed to 'InteractionContext'
Function Parameter Count Violation: Function should have 5 parameters or less: it currently has 6 (function_parameter_count)
Line Length Violation: Line should be 120 characters or less; currently it has 124 characters (line_length)
Prefer For-Where Violation: `where` clauses are preferred over a single `if` inside a `for` (for_where)
Line Length Violation: Line should be 120 characters or less; currently it has 121 characters (line_length)
Cyclomatic Complexity Violation: Function should have complexity 10 or less; currently complexity is 11 (cyclomatic_complexity)
Line Length Violation: Line should be 120 characters or less; currently it has 124 characters (line_length)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Line Length Violation: Line should be 120 characters or less; currently it has 143 characters (line_length)
Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
File Length Violation: File should contain 400 lines or less: currently contains 570 (file_length)
Line Length Violation: Line should be 120 characters or less; currently it has 126 characters (line_length)
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Line Length Violation: Line should be 120 characters or less; currently it has 152 characters (line_length)
Using '_' to ignore the result of a Void-returning function is redundant
Line Length Violation: Line should be 120 characters or less; currently it has 137 characters (line_length)
Line Length Violation: Line should be 120 characters or less; currently it has 122 characters (line_length)
Line Length Violation: Line should be 120 characters or less; currently it has 126 characters (line_length)
Function Body Length Violation: Function body should span 50 lines or less excluding comments and whitespace: currently spans 51 lines (function_body_length)
Todo Violation: TODOs should be resolved (Add finalized graphic) (todo)
Todo Violation: TODOs should be resolved (figure out something to do if ...) (todo)
Redundant Optional Initialization Violation: Initializing an optional variable with nil is redundant (redundant_optional_initialization)
'MapContentGestureContext' is deprecated: renamed to 'InteractionContext'
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 280 lines (type_body_length)
Line Length Violation: Line should be 120 characters or less; currently it has 174 characters (line_length)
Large Tuple Violation: Tuples should have at most 2 members (large_tuple)
Line Length Violation: Line should be 120 characters or less; currently it has 150 characters (line_length)
Instance method 'wait' is unavailable from asynchronous contexts; Use await fulfillment(of:timeout:enforceOrder:) instead; this is an error in Swift 6
Line Length Violation: Line should be 120 characters or less; currently it has 125 characters (line_length)
Expression implicitly coerced from 'URLResponse?' to 'Any'
Line Length Violation: Line should be 120 characters or less; currently it has 132 characters (line_length)
Annotations
Check notice on line 35 in iosApp/iosApp/Pages/Map/AnnotatedMap.swift
xcode-cloud / MBTA Transit Staging | PR Branch Workflow | iosAppRetries - iOS
iosApp/iosApp/Pages/Map/AnnotatedMap.swift#L35
'MapContentGestureContext' is deprecated: renamed to 'InteractionContext'
Loading