-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android.search,map): Style updates #745
Conversation
…cting route pills
LaunchedEffect(searchInputState, visible, globalResponse) { | ||
searchResultsVm.getSearchResults(searchInputState, globalResponse) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
previously, search results were not re-fetched when the globalResponse loaded for the first time, so on initial open of the search bar, "Recently viewed" would be blank.
Note to self: After #726 is merged, see if there are any issues with the search border changes here, or just keep it removed |
…pp into kb-non-p0-qa
9fb2d7d
to
79fd685
Compare
Summary
Ticket: 🤖 | non-P0 QA findings
What is this PR for?
This PR includes a few minor fixes to search and the map
iOS
android
withContext(Dispatchers.Default)
where possibleTesting
What testing have you done?