Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android.search,map): Style updates #745

Merged
merged 15 commits into from
Feb 18, 2025
Merged

fix(android.search,map): Style updates #745

merged 15 commits into from
Feb 18, 2025

Conversation

KaylaBrady
Copy link
Collaborator

@KaylaBrady KaylaBrady commented Feb 14, 2025

Summary

Ticket: 🤖 | non-P0 QA findings

What is this PR for?

This PR includes a few minor fixes to search and the map

  • Search bar padding & border fixes
    • I was not able to modify the search bar height with a reasonable amount of trying.
  • Search result station pills order, groups bus & CR pills
  • Search bug fix: Recently viewed no longer missing on first open
  • Map pulsing location, attribution alignment

iOS

  • If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?
    • Add temporary machine translations, marked "Needs Review"

android

  • All user-facing strings added to strings resource in alphabetical order
  • Expensive calculations are run in withContext(Dispatchers.Default) where possible

Testing

What testing have you done?

  • Added unit tests
  • Ran locally
    Screenshot_20250213_165616
    Screenshot_20250214_100825

@KaylaBrady KaylaBrady requested a review from a team as a code owner February 14, 2025 15:13
Comment on lines +83 to +85
LaunchedEffect(searchInputState, visible, globalResponse) {
searchResultsVm.getSearchResults(searchInputState, globalResponse)
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previously, search results were not re-fetched when the globalResponse loaded for the first time, so on initial open of the search bar, "Recently viewed" would be blank.

@KaylaBrady
Copy link
Collaborator Author

KaylaBrady commented Feb 14, 2025

Note to self: After #726 is merged, see if there are any issues with the search border changes here, or just keep it removed

@KaylaBrady KaylaBrady merged commit eab1441 into main Feb 18, 2025
6 checks passed
@KaylaBrady KaylaBrady deleted the kb-non-p0-qa branch February 18, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants