Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android.MorePage): Remove debug sentry crash button #766

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

KaylaBrady
Copy link
Collaborator

Summary

What is this PR for?
No ticket. Removes the sentry test crash button now that we know Sentry is properly configured. Something that is crawling the staging app keeps hitting this button and causing noise in our alerts channel.

iOS

  • If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?
    • Add temporary machine translations, marked "Needs Review"

android

  • All user-facing strings added to strings resource in alphabetical order
  • Expensive calculations are run in withContext(Dispatchers.Default) where possible

Testing

What testing have you done?

  • Ran locally, confirmed no crash button

@KaylaBrady KaylaBrady requested a review from a team as a code owner February 20, 2025 14:59
@KaylaBrady KaylaBrady requested a review from BrandonTR February 20, 2025 14:59
@KaylaBrady KaylaBrady merged commit b85b069 into main Feb 20, 2025
4 checks passed
@KaylaBrady KaylaBrady deleted the kb-remove-debug-crash-button branch February 20, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants