perf(VehiclesForRouteChannel): Use vehicles from PubSub instead of GenServer #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaylaBrady
added
the
deploy to dev-orange
KaylaBrady
force-pushed
the
kb-vehicles-ets
branch
from
cb47e06
to
f5869ff
Compare
KaylaBrady
force-pushed
the
kb-vehicles-ets
branch
from
f5869ff
to
cf56091
Compare
KaylaBrady
force-pushed
the
kb-vehicles-ets
branch
from
cf56091
to
4672541
Compare
KaylaBrady
commented
Oct 24, 2024
| @@ -31,14 +31,7 @@ defmodule MobileAppBackendWeb.PredictionsForStopsV2Channel do | |||
| @spec handle_info({:new_predictions, any()}, Phoenix.Socket.t()) :: | |||
| {:noreply, Phoenix.Socket.t()} | |||
| def handle_info({:new_predictions, new_predictions_for_stop}, socket) do | |||
| {time_micros, _result} = | |||
There was a problem hiding this comment.
tiny log cleanup while copying over behavior of predictions channel
EmmaSimon
approved these changes
Oct 24, 2024
|
@EmmaSimon thanks for asking - definitely worth running again, and I hadn't yet! Added results to the Load testing doc - this got us to push past 3,300 users at a rate of 5 users / second. I think we'll still want to tackle static data caching to improve that further, or start with a higher base # of instances running. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: [Name](https://app.asana.com/0/1205732265579288/1208619681848095/f)
What is this PR for?
Addresses the bottleneck found in Load Testing when many users are joining vehicles channels at once.
Vehicles.PubSubis largely a copy ofPredictions.PubSub- there is probably a good basis for extracting out common pieces, but I think it is worth saving that for a separate ticket.This does switch
VehicleChannelto use PubSub as well for consistency.Testing: