update code to use standard Zen Cart functionallity #7
Conversation
Zen4All
commented
Feb 17, 2016
Zen4All
commented
| @@ -213,20 +213,20 @@ | |||
| /* @var $epdlanguage_query type array */ | |||
| //$epdlanguage_query = $db->Execute("SELECT languages_id, name FROM ".TABLE_LANGUAGES." WHERE code = '".DEFAULT_LANGUAGE."'"); | |||
| if (!defined(DEFAULT_LANGUAGE)) { | |||
| $epdlanguage_query = ep_4_query("SELECT languages_id, code FROM " . TABLE_LANGUAGES . " ORDER BY languages_id LIMIT 1"); | |||
There was a problem hiding this comment.
This style of query offers in house error management and does not crash to resolve the issue by use of the ZC /cache or /logs directory or some other "outside" location, but instead provide a debug file that is readily available "on screen" for review.
|
Ok, I understand your point of view, so I'll leave the rest of the code alone. Though in my opinion it over complicates the code 😉 |
|
What we do for backwards compatibility... There WILL come a time when the "option" won't be available to use mysql_ type codes. I almost changed to ZC style queries when upgrading, but then I remembered the times I made an error in an import file and was thankful for the error logging introduced by chadd... Yes there are ZC plugins that can support, but didn't want to take this "backwards" or force a different style of usage. Besides that, as a benefit of how the errors are handled, processing continues even if one "row" has an error in it rather than fatally stopping. |
|
Also, don't get me wrong there may be other code improvements to be made and I appreciate the previous fix. Certainly would welcome a dutch or other translation if you are able. Particularly am interested in an italian translation seeing as the italian group won't allow me to have an account with. Them to request the same from there. |
|
I'll see what I can do about the Dutch translation. For my Italian is as bad as my French and Spanish 😆 . Maybe you could ask 100asa(https://www.zen-cart.com/member.php?31874-100asa) he is italian |
To return files to the status that mostly was done at least twice before.
