Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: #93 html tags not escaped on gitlab pull request decoration #216

Conversation

PiekJ
Copy link
Contributor

@PiekJ PiekJ commented Jul 20, 2020

Escapes HTML tags in GitLab Merge Request decorations. This PR fixes issue #93. This PR depends on PR #214.

…ation.

Added htmlEscaping to Textformatter and removed whitespace and begin and end for the text.
@teuno teuno force-pushed the bugfix/91-html-tags-not-escaped-on-gitlab-pull-request-decoration branch from ae5af24 to 1ab6ba5 Compare August 3, 2020 12:35
@PiekJ
Copy link
Contributor Author

PiekJ commented Aug 3, 2020

Removed PR #214 dependency so it can be reviewed independently. Squashed the commits too.

@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@mc1arke mc1arke merged commit af92519 into mc1arke:master Oct 24, 2020
@mc1arke
Copy link
Owner

mc1arke commented Oct 24, 2020

Merged. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants