Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sq 8 2+azure devops #218

Merged
merged 3 commits into from
Oct 27, 2020
Merged

Sq 8 2+azure devops #218

merged 3 commits into from
Oct 27, 2020

Conversation

jcuzzi
Copy link
Contributor

@jcuzzi jcuzzi commented Jul 22, 2020 •
edited
Loading

Implements #102

Add support for Azure DevOps PR Decoration
Notes:

The following should be set in the scanner properties:
sonar.pullrequest.vsts.instanceUrl=https://[organization].visualstudio.com/
sonar.pullrequest.vsts.project=[Project]
sonar.pullrequest.vsts.repository=[Repository]

Ensure that the following option is unchecked in the Azure DevOps Branch Policy configuration, otherwise an exception will be thrown:
"Reset status whenever there are new changes"

mc1arke
mc1arke requested changes Jul 22, 2020
View reviewed changes
.project Outdated Show resolved Hide resolved
...java/com/github/mc1arke/sonarqube/plugin/ce/pullrequest/azuredevops/model/CommentThread.java Outdated Show resolved Hide resolved
...java/com/github/mc1arke/sonarqube/plugin/ce/pullrequest/azuredevops/model/CommentThread.java Outdated Show resolved Hide resolved
...a/com/github/mc1arke/sonarqube/plugin/ce/pullrequest/azuredevops/model/GitStatusContext.java Outdated Show resolved Hide resolved
...n/java/com/github/mc1arke/sonarqube/plugin/ce/pullrequest/azuredevops/model/IdentityRef.java Outdated Show resolved Hide resolved
...1arke/sonarqube/plugin/ce/pullrequest/azuredevops/AzureDevOpsServerPullRequestDecorator.java Outdated Show resolved Hide resolved
...1arke/sonarqube/plugin/ce/pullrequest/azuredevops/AzureDevOpsServerPullRequestDecorator.java Outdated Show resolved Hide resolved
...1arke/sonarqube/plugin/ce/pullrequest/azuredevops/AzureDevOpsServerPullRequestDecorator.java Outdated Show resolved Hide resolved
...1arke/sonarqube/plugin/ce/pullrequest/azuredevops/AzureDevOpsServerPullRequestDecorator.java Outdated Show resolved Hide resolved
...1arke/sonarqube/plugin/ce/pullrequest/azuredevops/AzureDevOpsServerPullRequestDecorator.java Outdated Show resolved Hide resolved
@jcuzzi jcuzzi force-pushed the sq-8_2+azure-devops branch 3 times, most recently from 1f3a33e to 276089d Compare July 24, 2020 15:09
@jcuzzi jcuzzi mentioned this pull request Jul 24, 2020
Closed
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2020

SonarCloud Quality Gate failed.

Bug C 4 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 30 Code Smells

69.5% 69.5% Coverage
0.0% 0.0% Duplication

mc1arke
mc1arke requested changes Jul 26, 2020
View reviewed changes
Copy link
Owner

@mc1arke mc1arke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments from me. Please also ensure you've fixed all SonarCloud's findings or made it clear why you think any of them aren't relevant

...ithub/mc1arke/sonarqube/plugin/ce/pullrequest/azuredevops/model/AzurePullRequestDetails.java Outdated Show resolved Hide resolved
...ithub/mc1arke/sonarqube/plugin/ce/pullrequest/azuredevops/model/AzurePullRequestDetails.java Outdated Show resolved Hide resolved
...java/com/github/mc1arke/sonarqube/plugin/ce/pullrequest/azuredevops/model/CommentThread.java Outdated Show resolved Hide resolved
...java/com/github/mc1arke/sonarqube/plugin/ce/pullrequest/azuredevops/model/CommentThread.java Outdated Show resolved Hide resolved
...java/com/github/mc1arke/sonarqube/plugin/ce/pullrequest/azuredevops/model/CommentThread.java Outdated Show resolved Hide resolved
...m/github/mc1arke/sonarqube/plugin/ce/pullrequest/azuredevops/model/CommentThreadContext.java Outdated Show resolved Hide resolved
...n/java/com/github/mc1arke/sonarqube/plugin/ce/pullrequest/azuredevops/model/IdentityRef.java Outdated Show resolved Hide resolved
...1arke/sonarqube/plugin/ce/pullrequest/azuredevops/AzureDevOpsServerPullRequestDecorator.java Outdated Show resolved Hide resolved
...e/sonarqube/plugin/ce/pullrequest/azuredevops/AzureDevOpsServerPullRequestDecoratorTest.java Outdated Show resolved Hide resolved
...1arke/sonarqube/plugin/ce/pullrequest/azuredevops/AzureDevOpsServerPullRequestDecorator.java Outdated Show resolved Hide resolved
@jcuzzi jcuzzi force-pushed the sq-8_2+azure-devops branch 2 times, most recently from 335bc66 to 05142e9 Compare July 27, 2020 18:28
@jcuzzi jcuzzi force-pushed the sq-8_2+azure-devops branch 3 times, most recently from 928ade2 to 4c60a2b Compare July 31, 2020 20:25
@jcuzzi
Copy link
Contributor Author

jcuzzi commented Aug 3, 2020

@mc1arke Any other concerns with this PR?

@zverev-iv
Copy link

I can't wait for this PR merge :)

@jenciso jenciso mentioned this pull request Aug 11, 2020
Closed
@jcuzzi
Copy link
Contributor Author

jcuzzi commented Aug 14, 2020

@mc1arke Can you run this through SonarCloud again?

@jcuzzi
Copy link
Contributor Author

jcuzzi commented Sep 1, 2020

@mc1arke Can you run this through SonarCloud again?

Bump - been a while since I checked on the status here. Been using this branch in my production SQ server for a while now with no issues.

@mc1arke
Copy link
Owner

mc1arke commented Sep 1, 2020

Sorry, I've had a hard-disk failure on my laptop so don't have somewhere convenient to perform a final shake-down of this change before merge. I do want to get this merged and a release published, but you're going to have to wait a bit until I can get things sorted.

@jcuzzi
Copy link
Contributor Author

jcuzzi commented Sep 1, 2020

Sorry, I've had a hard-disk failure on my laptop so don't have somewhere convenient to perform a final shake-down of this change before merge. I do want to get this merged and a release published, but you're going to have to wait a bit until I can get things sorted.

Yeah, no problem. Thanks for the update.

@rezarms
Copy link

rezarms commented Oct 16, 2020

when is it gonna be released?
I'm waiting for that.

@jcuzzi
Copy link
Contributor Author

jcuzzi commented Oct 16, 2020

For those who need this feature now, you can use the build linked below. I've been using it in production for months with no problems:
https://github.com/jcuzzi/sonarqube-community-branch-plugin/releases/download/v1.4.1-SNAPSHOT/sonarqube-community-branch-plugin-1.4.1-SNAPSHOT.jar

@mc1arke
Copy link
Owner

mc1arke commented Oct 25, 2020

@jcuzzi could you take a look at the latest Sonarcloud result please?

@jcuzzi
Copy link
Contributor Author

jcuzzi commented Oct 25, 2020

@mc1arke I made some changes to fix the SonarCloud issues and add some additional unit tests.

@bbarman4u
Copy link

Awesome @jcuzzi ! Excited to see this PR finally getting close to moving to master ! Hope we see a released version soon...

@mc1arke
Copy link
Owner

mc1arke commented Oct 26, 2020

@jcuzzi Sorry to be a pain! Could you rebase your branch again please? I've merged another branch which is causing compilation failures in your change

Add PR Decoration Support for Azure DevOps Server
6189d19 
fixing space in url

fix PR URL

SonarCloud fixes

fix spacing issue

Reopen Azure Thread if SQ issue is open

fix enumeration property names for serialization.
remove reactivation of azure threads

filter azure threads without rightFileStart info

Cleanup and add tests

Fix merge conflicts
@jcuzzi
Copy link
Contributor Author

jcuzzi commented Oct 26, 2020

@mc1arke Think I got it all merged right

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 12 Code Smells

81.1% 81.1% Coverage
0.0% 0.0% Duplication

@mc1arke mc1arke merged commit f02f462 into mc1arke:master Oct 27, 2020
@mc1arke
Copy link
Owner

mc1arke commented Oct 27, 2020

Merged. Thanks for the contribution!

@jcuzzi jcuzzi deleted the sq-8_2+azure-devops branch November 12, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bambuca bambuca bambuca left review comments

@mc1arke mc1arke mc1arke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jcuzzi @zverev-iv @mc1arke @rezarms @bbarman4u @bambuca