Fix NPE when branch is orphaned #48
Conversation
This closes #47
| return new PullRequestInfo(jsonObject.get("key").getAsString(), jsonObject.get("branch").getAsString(), | ||
| jsonObject.get("base").getAsString(), parsedDate); | ||
| base, parsedDate); |
There was a problem hiding this comment.
This could probably have been more succinctly written as Optional.ofNullable(jsonObject.get("base")).orElse(null) which would prevent the need for variable assignment and additional null checks.
There was a problem hiding this comment.
the getAsString transformation in your code example is missing, which makes it much longer and unreadable if not in an extra var
There was a problem hiding this comment.
I've got no issue with it being in an extra var, it was the null checks that seemed unnecessary. Your change looks good to me. I presume you've verified this now works for you locally?
There was a problem hiding this comment.
it works in production on our server
There was a problem hiding this comment.
and the nullcheck is necessary to prevent the NPEs. Otherwise you cannot call getAsString. Optional.orElse does nothing differently
This closes #47