fix: use file urls for esm #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 67c03a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Logan McAnsh <logan@mcan.sh> Signed-off-by: Marc <39219018+VIEWVIEWVIEW@users.noreply.github.com>
Co-authored-by: Logan McAnsh <logan@mcan.sh> Signed-off-by: Marc <39219018+VIEWVIEWVIEW@users.noreply.github.com>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
mcansh
reviewed
Jun 13, 2024
mcansh
approved these changes
Jun 13, 2024
mcansh
added a commit
to nwleedev/remix-fastify
that referenced
this pull request
Jun 13, 2024
* Use file urls for esm Fixed mcansh#341 * Update packages/remix-fastify/src/plugin.ts Co-authored-by: Logan McAnsh <logan@mcan.sh> Signed-off-by: Marc <39219018+VIEWVIEWVIEW@users.noreply.github.com> * Update packages/remix-fastify/src/plugin.ts Co-authored-by: Logan McAnsh <logan@mcan.sh> Signed-off-by: Marc <39219018+VIEWVIEWVIEW@users.noreply.github.com> * Update plugin.ts Signed-off-by: Logan McAnsh <logan@mcan.sh> * Create small-points-teach.md Signed-off-by: Logan McAnsh <logan@mcan.sh> * Update plugin.ts Signed-off-by: Logan McAnsh <logan@mcan.sh> --------- Signed-off-by: Marc <39219018+VIEWVIEWVIEW@users.noreply.github.com> Signed-off-by: Logan McAnsh <logan@mcan.sh> Co-authored-by: Logan McAnsh <logan@mcan.sh>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #341 on Windows. I manually verified if it works, using the local Vite example and my own project. Tests pass. (All Windows)
Unfortunately I don't have a Linux machine at hand, so it would be nice if someone could take a look if it breaks anything on Linux. :)