For mozilla-mobile#24210: Remove wrapper from copy url event.

mcarare · Apr 6, 2022 · 3f426bf · 3f426bf
1 parent a1061a3
commit 3f426bf
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/app/src/main/java/org/mozilla/fenix/components/metrics/Event.kt b/app/src/main/java/org/mozilla/fenix/components/metrics/Event.kt
@@ -126,8 +126,6 @@ sealed class Event {
 
     object TabSettingsOpened : Event()
 
-    object CopyUrlUsed : Event()
-
     object SyncedTabOpened : Event()
 
     object RecentlyClosedTabsOpenedOld : Event()

diff --git a/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt b/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt
@@ -367,9 +367,6 @@ private val Event.wrapper: EventWrapper<*>?
         is Event.ProgressiveWebAppInstallAsShortcut -> EventWrapper<NoExtraKeys>(
             { ProgressiveWebApp.installTap.record(it) }
         )
-        is Event.CopyUrlUsed -> EventWrapper<NoExtraKeys>(
-            { Events.copyUrlTapped.record(it) }
-        )
 
         is Event.SyncedTabOpened -> EventWrapper<NoExtraKeys>(
             { Events.syncedTabOpened.record(it) }

diff --git a/app/src/main/java/org/mozilla/fenix/utils/ToolbarPopupWindow.kt b/app/src/main/java/org/mozilla/fenix/utils/ToolbarPopupWindow.kt
@@ -18,11 +18,12 @@ import mozilla.components.browser.state.selector.selectedTab
 import mozilla.components.browser.state.store.BrowserStore
 import org.mozilla.fenix.R
 import org.mozilla.fenix.components.FenixSnackbar
-import org.mozilla.fenix.components.metrics.Event
 import org.mozilla.fenix.ext.components
 import java.lang.ref.WeakReference
 import mozilla.components.browser.state.selector.findCustomTab
+import mozilla.components.service.glean.private.NoExtras
 import mozilla.components.support.base.log.logger.Logger
+import org.mozilla.fenix.GleanMetrics.Events
 import org.mozilla.fenix.databinding.BrowserToolbarPopupWindowBinding
 
 object ToolbarPopupWindow {
@@ -77,7 +78,7 @@ object ToolbarPopupWindow {
                         .setText(context.getString(R.string.browser_toolbar_url_copied_to_clipboard_snackbar))
                         .show()
                 }
-                context.components.analytics.metrics.track(Event.CopyUrlUsed)
+                Events.copyUrlTapped.record(NoExtras())
             }
         }