Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement edge-to-edge #80

Open
trixter13 opened this issue Mar 6, 2025 · 6 comments
Open

Implement edge-to-edge #80

trixter13 opened this issue Mar 6, 2025 · 6 comments
Labels
bug Something isn't working

Comments

@trixter13
Copy link

Description

On my Pixel 8 Pro, there are no buttons to interact with anymore since the 2.0 redesign.
Image

To reproduce

Steps to reproduce the behaviour:

  1. Update to 2.0
  2. Open the app

Expected behaviour

There are buttons to set the location etc.

Screenshots

No response

Logcat

No response

Additional context

No response

Device

Pixel 8 Pro

OS

GrapheneOS 2025030300

FakeTraveler version

2.0.0

@trixter13 trixter13 added the bug Something isn't working label Mar 6, 2025
@ThexXTURBOXx
Copy link
Collaborator

Interesting - I have seen this in an emulator running the current beta of Android 16, but thought it would be okay on a physical device. Apparently not.
Will investigate!

@An-anonymous-coder
Copy link

Mine doesn't even have a map. (Pixel 8 running GrapheneOS. The app has Network permissions disabled)

Image

@ThexXTURBOXx
Copy link
Collaborator

Mine doesn't even have a map. (Pixel 8 running GrapheneOS. The app has Network permissions disabled)

The map needs a working internet connection to work, there is no way around that (other than migrating to a Google Maps implementation, but I will stay with OSM)

@An-anonymous-coder
Copy link

A local download of OSM could be added to the app, couldn't it?

Before the redesign the app worked fully offline.

@ThexXTURBOXx
Copy link
Collaborator

A local download of OSM could be added to the app, couldn't it?

That is rather infeasible as it takes a huge amount of space:

Image

Before the redesign the app worked fully offline.

Actually, no. This would not have been possible in any way - and after some testing, I can confirm that the map did not work offline (see screenshot below).
Obviously, the app itself still works, including all the functions, except for the map. But you can manually set a mock location using geo coordinates.

Image

Interesting - I have seen this in an emulator running the current beta of Android 16, but thought it would be okay on a physical device. Apparently not.

Found out that this is due to the new edge-to-edge layout, which is forced with target SDK 35. One can opt out using windowOptOutEdgeToEdgeEnforcement, but that would just be a workaround.
I will try to properly migrate - but if that fails, I will use the workaround for now...

ThexXTURBOXx added a commit that referenced this issue Mar 6, 2025
for now... At some point we need to fix the layout to be future-proof!
Related: #80
@ThexXTURBOXx
Copy link
Collaborator

I will send version 2.1.0 off to FDroid now - should be public in at most a week.
I deployed the workaround for now as it needs a bit more tinkering to fully fix edge-to-edge...

@ThexXTURBOXx ThexXTURBOXx changed the title [Bug]: 2.0 Resdesign has no buttons Implement edge-to-edge Mar 6, 2025
@ThexXTURBOXx ThexXTURBOXx marked this as a duplicate of #81 Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants