Skip to content
This repository has been archived by the owner on May 30, 2024. It is now read-only.

refactor: FastAPI -> Django migration #41

Merged
merged 11 commits into from
Nov 27, 2023
Merged

Conversation

mcataford
Copy link
Owner

Description

This changeset migrates the backend from FastAPI to Django. The main rationale behind it is about framework stability and ecosystem - Django is closer to "the devil you know" and has a bigger contributor base at the moment, making it more likely to weather the storm.

The need for async support is what had initially motivated the choice to play with FastAPI, but Django's async support seems decent enough to enable what needs enablin'.

Being early on in the project, it's a now-or-never scenario.

Approach

Django is first introduced as a parallel path under backend/rotini_django and has its own variant of the tooling (see Taskfile.backend.yml). Then the APIs are moved over to the Django app until it's at parity. Then rotini_django -> rotini.

Copy link

gitguardian bot commented Nov 17, 2023

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
8785839 Django Secret Key 205f661 backend/rotini_django/base/settings.py View secret
8785839 Django Secret Key c7e49ab backend/rotini_django/base/settings.py View secret
8785839 Django Secret Key 2db0d9e backend/rotini/base/settings.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@mcataford mcataford force-pushed the feat/django-migration branch from 1a074ab to bf83002 Compare November 18, 2023 13:46
feat: file ownership basics

feat: gaps in test compatibility
@mcataford mcataford force-pushed the feat/django-migration branch from bf83002 to a3355ac Compare November 19, 2023 21:33
@mcataford
Copy link
Owner Author

Note: placeholder secrets previously included were rotated.

@mcataford mcataford marked this pull request as ready for review November 27, 2023 02:34
@mcataford mcataford merged commit 0242b2d into main Nov 27, 2023
17 checks passed
@mcataford mcataford deleted the feat/django-migration branch November 27, 2023 02:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant