This repository has been archived by the owner on May 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
8785839 | Django Secret Key | 205f661 | backend/rotini_django/base/settings.py | View secret |
8785839 | Django Secret Key | c7e49ab | backend/rotini_django/base/settings.py | View secret |
8785839 | Django Secret Key | 2db0d9e | backend/rotini/base/settings.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
mcataford
force-pushed
the
feat/django-migration
branch
from
November 18, 2023 13:46
1a074ab
to
bf83002
Compare
feat: file ownership basics feat: gaps in test compatibility
mcataford
force-pushed
the
feat/django-migration
branch
from
November 19, 2023 21:33
bf83002
to
a3355ac
Compare
Note: placeholder secrets previously included were rotated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changeset migrates the backend from FastAPI to Django. The main rationale behind it is about framework stability and ecosystem - Django is closer to "the devil you know" and has a bigger contributor base at the moment, making it more likely to weather the storm.
The need for async support is what had initially motivated the choice to play with FastAPI, but Django's async support seems decent enough to enable what needs enablin'.
Being early on in the project, it's a now-or-never scenario.
Approach
Django is first introduced as a parallel path under
backend/rotini_django
and has its own variant of the tooling (seeTaskfile.backend.yml
). Then the APIs are moved over to the Django app until it's at parity. Thenrotini_django -> rotini
.