Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect parameter not taken into account in the client creation #3

Closed
abarre opened this issue Jul 3, 2012 · 3 comments
Closed

connect parameter not taken into account in the client creation #3

abarre opened this issue Jul 3, 2012 · 3 comments

Comments

@abarre
Copy link
Contributor

abarre commented Jul 3, 2012

Hi,

{connect : false} in the createClient function is turned to true in the function.

Please change the line ( https://github.com/mcavage/node-zkplus/blob/master/lib/index.js#L34):

connect: options.connect || true (which is obviously always true)

to

connect: (options.connect !== undefined ? options.connect : true)

Regards,
Anthony.

@mcavage
Copy link
Owner

mcavage commented Jul 3, 2012

Thanks for the catch :) - obviously no tests previously existed that checked that :\

@mcavage
Copy link
Owner

mcavage commented Jul 5, 2012

Sorry this took so long; I was on the road - I'll look at the other one as well.

@abarre
Copy link
Contributor Author

abarre commented Jul 5, 2012

Thanks, if you don't have enough time. I think I can prepare a pull request for this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants