We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi,
{connect : false} in the createClient function is turned to true in the function.
Please change the line ( https://github.com/mcavage/node-zkplus/blob/master/lib/index.js#L34):
connect: options.connect || true (which is obviously always true)
to
connect: (options.connect !== undefined ? options.connect : true)
Regards, Anthony.
The text was updated successfully, but these errors were encountered:
Thanks for the catch :) - obviously no tests previously existed that checked that :\
Sorry, something went wrong.
GH-3: connect parameter not accounted for
c0df56b
Sorry this took so long; I was on the road - I'll look at the other one as well.
Thanks, if you don't have enough time. I think I can prepare a pull request for this weekend.
No branches or pull requests
Hi,
{connect : false} in the createClient function is turned to true in the function.
Please change the line ( https://github.com/mcavage/node-zkplus/blob/master/lib/index.js#L34):
connect: options.connect || true (which is obviously always true)
to
connect: (options.connect !== undefined ? options.connect : true)
Regards,
Anthony.
The text was updated successfully, but these errors were encountered: