Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug: error happens if no callback is set when calling client.close() #38

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

laike9m
Copy link

@laike9m laike9m commented Jan 27, 2015

Hi mcavage, I've encountered a bug when invoking client.close()

/Users/laike9m/ICT/ICT_Projects/zk/node_modules/zkplus/node_modules/once/once.js:16
    return f.value = fn.apply(this, arguments)
                        ^
TypeError: Cannot call method 'apply' of undefined
    at f (/Users/laike9m/ICT/ICT_Projects/zk/node_modules/zkplus/node_modules/once/once.js:16:25)
    at Client.<anonymous> (/Users/laike9m/ICT/ICT_Projects/zk/node_modules/zkplus/lib/client.js:215:17)
    at Client.f (/Users/laike9m/ICT/ICT_Projects/zk/node_modules/zkplus/node_modules/once/once.js:16:25)
    at Client.g (events.js:180:16)
    at Client.emit (events.js:117:20)
    at Client.defaultStateListener (/Users/laike9m/ICT/ICT_Projects/zk/node_modules/zkplus/node_modules/node-zookeeper-client/index.js:52:14)
    at Client.emit (events.js:95:17)
    at Client.onConnectionManagerState (/Users/laike9m/ICT/ICT_Projects/zk/node_modules/zkplus/node_modules/node-zookeeper-client/index.js:262:14)
    at ConnectionManager.emit (events.js:95:17)
    at ConnectionManager.setState (/Users/laike9m/ICT/ICT_Projects/zk/node_modules/zkplus/node_modules/node-zookeeper-client/lib/ConnectionManager.js:168:14)

The reason is clear: In lib/client.js line 198

cb = once(cb);

and this is what once do

function once (fn) {
  var f = function () {
    if (f.called) return f.value
    f.called = true
    return f.value = fn.apply(this, arguments)
  }
  f.called = false
  return f
}

Therefore, even though cb is undefined, it becomes a function after calling once(cb), so in line 209 and line 214, the if(cb) judgement breaks cause it's always true. Then cb gets called, but since fn is undefiend, fn.apply(this, arguments) raise an error.

I've made the fix so that if cb is undefined, once(cb) won't be called, and the subsequent judgement won't break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant