Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use full certificate chain for webhook
The webhook service is currently limited to using a certificate directly issued by a trusted CA; it will silently ignore any intermediate certificates that are present in the certificate file. The currently released versions of the Ruby OpenSSL libraries do not provide any clean way to load a certificate chain from a file. We therefore split the file using the BEGIN/END markers as per RFC 7468, and construct the certificate chain directly. No tests are extended to cover this enhancement, since there is no existing test coverage for the use of HTTPS certificates by the webhook. All current tests use plain HTTP via http://localhost:8088. Fixes voxpupuli#510 Signed-off-by: Michael Brown <mbrown@fensystems.co.uk>
- Loading branch information