Skip to content

Commit

Permalink
Fix webhook deployment on IPv6 machines
Browse files Browse the repository at this point in the history
The default bind_address is currently "0.0.0.0", which causes the
webhook to listen only for IPv4 connections.  Change the default to
"*" so that the webhook will listen for both IPv4 and IPv6
connections.

Fixes voxpupuli#490

Signed-off-by: Michael Brown <mbrown@fensystems.co.uk>
  • Loading branch information
mcb30 committed Mar 29, 2020
1 parent 4152610 commit ab4a82e
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion manifests/params.pp
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@
$mc_git_ssl_no_verify = 0

# Webhook configuration information
$webhook_bind_address = '0.0.0.0'
$webhook_bind_address = '*'
$webhook_port = '8088'
$webhook_access_logfile = '/var/log/webhook/access.log'
$webhook_client_cfg = '/var/lib/peadmin/.mcollective'
Expand Down
18 changes: 9 additions & 9 deletions spec/classes/webhook/config_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
content = '---
access_logfile: "/var/log/webhook/access.log"
allow_uppercase: true
bind_address: "0.0.0.0"
bind_address: "*"
certname: "peadmin"
certpath: "/var/lib/peadmin/.mcollective.d"
client_cfg: "/var/lib/peadmin/.mcollective"
Expand Down Expand Up @@ -83,7 +83,7 @@
content = '---
access_logfile: "/var/log/webhook/access.log"
allow_uppercase: true
bind_address: "0.0.0.0"
bind_address: "*"
certname: "peadmin"
certpath: "/var/lib/peadmin/.mcollective.d"
client_cfg: "/var/lib/peadmin/.mcollective"
Expand Down Expand Up @@ -147,7 +147,7 @@
content = '---
access_logfile: "/var/log/webhook/access.log"
allow_uppercase: true
bind_address: "0.0.0.0"
bind_address: "*"
client_cfg: "/var/lib/peadmin/.mcollective"
client_timeout: "120"
command_prefix: "umask 0022;"
Expand Down Expand Up @@ -192,7 +192,7 @@
content = '---
access_logfile: "/var/log/webhook/access.log"
allow_uppercase: true
bind_address: "0.0.0.0"
bind_address: "*"
client_cfg: "/var/lib/peadmin/.mcollective"
client_timeout: "120"
command_prefix: "umask 0022;"
Expand Down Expand Up @@ -236,7 +236,7 @@
content = '---
access_logfile: "/var/log/webhook/access.log"
allow_uppercase: true
bind_address: "0.0.0.0"
bind_address: "*"
client_cfg: "/var/lib/peadmin/.mcollective"
client_timeout: "120"
command_prefix: "umask 0022;"
Expand Down Expand Up @@ -281,7 +281,7 @@
content = '---
access_logfile: "/var/log/webhook/access.log"
allow_uppercase: true
bind_address: "0.0.0.0"
bind_address: "*"
bitbucket_secret: "secret"
client_cfg: "/var/lib/peadmin/.mcollective"
client_timeout: "120"
Expand Down Expand Up @@ -326,7 +326,7 @@
content = '---
access_logfile: "/var/log/webhook/access.log"
allow_uppercase: true
bind_address: "0.0.0.0"
bind_address: "*"
client_cfg: "/var/lib/peadmin/.mcollective"
client_timeout: "120"
command_prefix: "umask 0022;"
Expand Down Expand Up @@ -371,7 +371,7 @@
content = '---
access_logfile: "/var/log/webhook/access.log"
allow_uppercase: true
bind_address: "0.0.0.0"
bind_address: "*"
client_cfg: "/var/lib/peadmin/.mcollective"
client_timeout: "120"
command_prefix: "umask 0022;"
Expand Down Expand Up @@ -458,7 +458,7 @@
content = '---
access_logfile: "/var/log/webhook/access.log"
allow_uppercase: true
bind_address: "0.0.0.0"
bind_address: "*"
client_cfg: "/var/lib/peadmin/.mcollective"
client_timeout: "120"
command_prefix: "umask 0022;"
Expand Down

0 comments on commit ab4a82e

Please sign in to comment.