Fixes from -Wall checks with Catena-Arduino-Platform

README.md

@@ -430,7 +430,10 @@ Much more elaborate uses can be found in the MCCI [Catena-Arduino-Platform](http
 
 - Head includes the following changes.
 
-  - Correct error in logging, missing `return true` in `Arduino_LoRaWAN::cEventLog::processSingleEvent()` ([#191](https://github.com/mcci-catena/arduino-lorawan/issues/169)). This is v0.9.2-pre1.
+  - Fix `-Wunused-parameter` warnings from gcc. ([#196](https://github.com/mcci-catena/arduino-lorawan/issues/196)). This is v0.9.2-pre3.
+  - Apply pre-release version to `library.properties` and `library.json` ([#195](https://github.com/mcci-catena/arduino-lorawan/issues/195)). This is v0.9.2-pre2.
+  - Correct error, missing `return true` at end of `Arduino_LoRaWAN::ApplySessionState()`. ([#194])(https://github.com/mcci-catena/arduino-lorawan/issues/194)).
+  - Correct error in logging, missing `return true` in `Arduino_LoRaWAN::cEventLog::processSingleEvent()` ([#191](https://github.com/mcci-catena/arduino-lorawan/issues/191)). This is v0.9.2-pre1.
 
 - v0.9.1 includes the following changes.
 

library.json

@@ -31,7 +31,7 @@
       "authors": ["Terry Moore <tmm@mcci.com>"]
     }
   ],
-  "version": "0.9.1",
+  "version": "0.9.2-pre3",
   "frameworks": "arduino",
   "platforms": "*"
 }

library.properties

@@ -1,5 +1,5 @@
 name=MCCI Arduino LoRaWAN Library
-version=0.9.1
+version=0.9.2-pre3
 author=Terry Moore, ChaeHee Won
 maintainer=Terry Moore <tmm@mcci.com>
 sentence=High-level library for LoRaWAN-based Arduino end-devices.

src/Arduino_LoRaWAN.h

@@ -34,7 +34,7 @@ Copyright notice:
 ///     \ref ARDUINO_LORAWAN_VERSION_COMPARE_LT() to compare relative versions.
 ///
 #define ARDUINO_LORAWAN_VERSION \
-        ARDUINO_LORAWAN_VERSION_CALC(0, 9, 2, 1) /* v0.9.2-pre1 */
+        ARDUINO_LORAWAN_VERSION_CALC(0, 9, 2, 3) /* v0.9.2-pre3 */
 
 #define ARDUINO_LORAWAN_VERSION_GET_MAJOR(v)    \
         (((v) >> 24u) & 0xFFu)
@@ -844,6 +844,10 @@ class Arduino_LoRaWAN
                         size_t nExtraSessionInfo
                         )
                 {
+                MCCIADK_API_PARAMETER(SessionInfo);
+                MCCIADK_API_PARAMETER(pExtraSessionInfo);
+                MCCIADK_API_PARAMETER(nExtraSessionInfo);
+
                 // default: do nothing.
                 }
 
@@ -854,6 +858,8 @@ class Arduino_LoRaWAN
                 SessionState &State
                 )
                 {
+                MCCIADK_API_PARAMETER(State);
+
                 // default: not implemented.
                 return false;
                 }
@@ -866,6 +872,8 @@ class Arduino_LoRaWAN
                 const SessionState &State
                 )
                 {
+                MCCIADK_API_PARAMETER(State);
+
                 // default: do nothing.
                 }
 

src/lib/arduino_lorawan_sessionstate.cpp

@@ -411,6 +411,7 @@ Arduino_LoRaWAN::ApplySessionState(
             LMIC_disableChannel(ch);
         }
 #endif
+    return true;
     }
 
 #undef FUNCTION