Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config structure simplification #19

Merged
merged 1 commit into from
Sep 26, 2023
Merged

config structure simplification #19

merged 1 commit into from
Sep 26, 2023

Conversation

pilgreen
Copy link
Contributor

What does this PR do?

This is a different sort of thing that what we've been doing. Instead of reviewing a specifc workflow for specific output, how do you feel about just messing with the configs a bit locally to see how they feel? This will not merge into main. I've created a new rc-v2 branch to gather all the updates for the next version.

I've got you both on here for feedback, and am simply looking for a thumbs up meaning "good enough for now let's proceed," or a chat about how we'd like to change it. There will be more changes down the line.

Side note Julia, I was able to pick the branch I want this to merge into when making this PR.

@pilgreen pilgreen mentioned this pull request Sep 22, 2023
@gabrielakhanna
Copy link
Contributor

Hi Jay! This is looking good to me! I really like that the cadence is at the top of the file. Just for clarification, what exactly does the "cue" number represent (as seen in the story config file)?

Copy link
Contributor

@julia-smith julia-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pilgreen This is nice! Didn't run into any issues in testing.

Copy link
Contributor

@gabrielakhanna gabrielakhanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@pilgreen pilgreen merged commit 4eae0b7 into rc-v2 Sep 26, 2023
@pilgreen pilgreen deleted the config-cleanup branch September 26, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants