Use detector zenith to check for cached value for IceCube-centered atmosphere #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't it just enough to set to 180 degree and then try to set 0 back to reproduce the problem that was solved, i.e. without setting the angle to 0 at the beginning? |
|
Maybe yes? |
jncots
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous version of the IceCube-centered atmosphere, the upgoing zenith angle >90 degree has been subtracted from 180 to obtain the equivalent zenith at the surface. This value (>90 degrees) has been used to store the previous value. If one requests after a calculation for 0deg, a calculation for 180deg, and then asks again for 0 degree, it will stick to 180 degrees since the last surface zenith is 0 deg in both cases. By storing the last detector zenith instead of the surface zenith, the check for the previous value will correctly detect the change and recalculate the spline.