Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleaned up the planner + controller interface #238

Merged
merged 7 commits into from
Sep 11, 2023
Merged

Conversation

antoinedang
Copy link
Contributor

@antoinedang antoinedang commented Sep 9, 2023

Related Issue(s)

Changes Made

  • remove callback argument to controller functions in planner (never used except search where it wasnt necessary)
  • fix bug with face_destination on move()'s
  • replace delta moves that were used to stay in place with calls to freeze position/rotation
  • rename stop_in_place to freeze_pose
  • add search depth parameters in search substates
  • remove old comments

Rationale/Other Solutions Considered

  • dirty planner need clean

Tests Done

Required Wiki Changes (if any)

  • need to update planner/controller interface

@frompotenza
Copy link
Contributor

frompotenza commented Sep 9, 2023

TESTS NOT DONE. WILL DO TOMORROW

@frompotenza frompotenza merged commit 0f9e3d1 into noetic Sep 11, 2023
2 checks passed
@frompotenza frompotenza deleted the clean-planner branch September 11, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants