Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerize #259

Merged
merged 14 commits into from
Sep 19, 2023
Merged

Dockerize #259

merged 14 commits into from
Sep 19, 2023

Conversation

MrMondrian
Copy link
Contributor

@MrMondrian MrMondrian commented Sep 19, 2023 •
edited
Loading

Related Issue(s)

Changes Made

  • Add docker file, fix install script error, change workflow to use custom docker image, no need to install dependencies in actions container anymore

Rationale/Other Solutions Considered

  • Could keep it the way it is, but this could speed up actions. also nice to have a docker image if ever needed. ie: all three projects need to share a desktop in medn

Tests Done

  • Ran the catkin build action

Required Wiki Changes (if any)

  • Could add a docker section

@MrMondrian MrMondrian closed this Sep 19, 2023
@MrMondrian MrMondrian reopened this Sep 19, 2023
@MrMondrian MrMondrian closed this Sep 19, 2023
@MrMondrian MrMondrian reopened this Sep 19, 2023
@antoinedang antoinedang self-requested a review September 19, 2023 17:58
@frompotenza frompotenza merged commit 5888ddc into noetic Sep 19, 2023
2 checks passed
@frompotenza frompotenza deleted the dockerize branch September 19, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frompotenza frompotenza frompotenza approved these changes

@antoinedang antoinedang antoinedang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MrMondrian @antoinedang @frompotenza