add basic qe+be support for user field #110

mcguffin · Aug 25, 2021 · df91154 · df91154
1 parent 9dad612
commit df91154
Show file tree

Hide file tree

Showing 16 changed files with 96 additions and 29 deletions.
diff --git a/css/acf-qef-field-group.css b/css/acf-qef-field-group.css
diff --git a/css/acf-quickedit.css b/css/acf-quickedit.css
diff --git a/include/ACFQuickEdit/Admin/Admin.php b/include/ACFQuickEdit/Admin/Admin.php
@@ -136,7 +136,7 @@ public function ajax_get_acf_post_meta( $params ) {
 
 					if ( $field_object = Fields\Field::getFieldObject( $field ) ) {
 						$value = $field_object->get_value( $object_id, false );
-
+error_log(var_export($value,true));
 						if ( ! isset( $data[ $key ] ) ) {
 							// first iteration - always set value
 							$val = $field_object->get_value( $object_id, false );

diff --git a/include/ACFQuickEdit/Fields/Field.php b/include/ACFQuickEdit/Fields/Field.php
@@ -77,8 +77,8 @@ public static function get_types() {
 			'taxonomy'			=> [ 'column' => true,		'quickedit' => true,	'bulkedit' => true ],
 			'user'				=> [
 				'column'	=> current_user_can('list_users'),
-				'quickedit'	=> false,
-				'bulkedit'	=> false
+				'quickedit'	=> current_user_can('list_users'),
+				'bulkedit'	=> current_user_can('list_users')
 			],
 
 			// jQuery
@@ -373,19 +373,22 @@ public function sanitize_value( $value, $context = 'db' ) {
 	 *	@param array $arr
 	 */
 	protected function sanitize_strings_array( $arr ) {
-		$arr = $arr;
-		array_walk( $arr, [ $this, '_sanitize_strings_array_cb' ] );
-		return $arr;
+
+		return array_combine(
+			array_map( [ $this, 'sanitize_string_or_leave_int' ], array_keys( $arr ) ),
+			array_map( 'sanitize_text_field', array_values( $arr ) )
+		);
+
 	}
 
 	/**
 	 *	array_walk callback
 	 */
-	private function _sanitize_strings_array_cb( &$value, &$key ) {
-		if ( ! is_int( $key ) ) {
-			$key = sanitize_text_field( $key );
+	private function sanitize_string_or_leave_int( $value ) {
+		if ( is_int( $value ) ) {
+			return $value;
 		}
-		$value = sanitize_text_field( $value );
+		return sanitize_text_field( $value );
 	}
 
 }
diff --git a/include/ACFQuickEdit/Fields/UserField.php b/include/ACFQuickEdit/Fields/UserField.php
@@ -5,7 +5,7 @@
 if ( ! defined( 'ABSPATH' ) )
 	die('Nope.');
 
-class UserField extends Field {
+class UserField extends SelectField {
 
 	/**
 	 *	@inheritdoc
@@ -27,11 +27,35 @@ public function render_column( $object_id ) {
 
 	}
 
+
 	/**
 	 *	@inheritdoc
 	 */
-	public function sanitize_value( $value, $context = 'db' ) {
+	public function render_input( $input_atts, $is_quickedit = true ) {
+		$get_users_args = [
+			'fields' => [ 'ID', 'user_nicename' ],
+		];
+
+		if ( ! empty( $this->acf_field['role'] ) ) {
+			$get_users_args['role__in'] = $this->acf_field['role'];
+		}
+		$users = get_users($get_users_args);
+		$this->acf_field['ui'] = true;
+		$this->acf_field['choices'] = array_combine(
+			array_map( function($user) { return $user->ID; }, $users ),
+			array_map( function($user) { return $user->user_nicename; }, $users ),
+		);
+		return parent::render_input( $input_atts, $is_quickedit );
+
+	}
 
+	/**
+	 *	@inheritdoc
+	 */
+	public function sanitize_value( $value, $context = 'db' ) {
+		if ( is_array( $value ) ) {
+			return array_map( 'intval', $value );
+		}
 		return intval( $value );
 
 	}

diff --git a/js/acf-columns.js b/js/acf-columns.js
diff --git a/js/acf-qef-field-group.js b/js/acf-qef-field-group.js
diff --git a/js/acf-quickedit.js b/js/acf-quickedit.js
diff --git a/src/js/lib/fields.js b/src/js/lib/fields.js
@@ -18,6 +18,8 @@ import textarea from 'fields/textarea.js'
 import time_picker from 'fields/time_picker.js'
 import true_false from 'fields/true_false.js'
 
+const user = Object.assign({},select,{type:'user'} );
+
 const View = wp.media.View.extend({
 	events:{
 		'change [type="checkbox"][data-is-do-not-change="true"]' : 'dntChanged',
@@ -150,7 +152,7 @@ field.add_type( button_group );
 field.add_type( select );
 
 /**
- *	field type select
+ *	field type post_object
  */
 field.add_type( post_object );
 
@@ -159,6 +161,11 @@ field.add_type( post_object );
  */
 field.add_type( taxonomy );
 
+/**
+ *	field type user
+ */
+field.add_type( user );
+
 /**
  *	field type true_false
  */

diff --git a/test/acf-json/group_acf_qef_basic.json b/test/acf-json/group_acf_qef_basic.json
@@ -174,7 +174,7 @@
     "label_placement": "top",
     "instruction_placement": "label",
     "hide_on_screen": "",
-    "active": 1,
+    "active": 0,
     "description": "",
     "modified": 1567242877
 }
diff --git a/test/acf-json/group_acf_qef_choice.json b/test/acf-json/group_acf_qef_choice.json
@@ -178,7 +178,7 @@
     "label_placement": "top",
     "instruction_placement": "label",
     "hide_on_screen": "",
-    "active": 1,
+    "active": 0,
     "description": "",
     "modified": 1566807827
 }