Fix comparison bugs in SQ code decoder #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 5, 2019 04:28
Compiling with -Wextra shows: warning: comparison of integer expressions of different signedness The fix from "Fix integer promotion bug" is not enough. Scanning other barcode formats unveils more comparison bugs. Thus, fix all comparison warnings in the SQ code decoder. Signed-off-by: Javier Serrano Polo <javier@jasp.net>
SQ code is not listed as a supported symbology. Thus, fix the warning message. Signed-off-by: Javier Serrano Polo <javier@jasp.net>
|
Indeed it seems that the problems seem to be solved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have fixed all comparison warnings that were revealed when compiling with
-Wextra. Infinite loops should not happen. Tested withexamples/*.png,/usr/share/icons/Adwaita/96x96/status/*.png, and one PDF.Closes #8.