-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SQ code support #2
Conversation
Thanks for the pull request. The patches themself look good, although I was unable to test the SQ code parser. A few comments:
(yeah, I know, it also doesn't mention QR... feel free to add it as well)
|
Add support for SQ code, a simple 2D barcode. zbarimg works with images without noise elements. Language bindings have not been tested. Signed-off-by: Javier Serrano Polo <javier@jasp.net>
SQ code assumes a square outline. Bad images may break this assumption and cause out-of-bounds access. To fix this, add sanity checks. Signed-off-by: Javier Serrano Polo <javier@jasp.net>
Building zbarcam-gtk fails because libzbar is missing from the command line. Thus, add the missing library. Signed-off-by: Javier Serrano Polo <javier@jasp.net>
Bad images trigger an integer type promotion bug in the SQ code decoder. Thus, clarify what we want. Signed-off-by: Javier Serrano Polo <javier@jasp.net>
zbarimg shows a warning when barcode is not detected. Print QR code and SQ code in currently supported symbologies. Signed-off-by: Javier Serrano Polo <javier@jasp.net>
This is a real-life example of SQ code. The two barcodes are equivalent. One is generated by the encoder. The other is scanned from paper. Signed-off-by: Javier Serrano Polo <javier@jasp.net>
Done. |
See issue #8 While this is not solved, I'll disable sqcode from the default and add a warning. |
FYI, I got a hard to track bug with SQ code. Please see: It is trigged when trying to read or set ZBAR_CFG_UNCERTAINTY for the SQ decoder. Only caught because zbarcam-qt now reads all configurations from all enabled decoders. |
This patch adds support for SQ code, a simple 2D barcode.