Force binary encoding for multipart file/buffer fields

Fixes tomas#403
mciasuen · May 9, 2022 · cdd613a · cdd613a
1 parent e5dee92
commit cdd613a
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/lib/multipart.js b/lib/multipart.js
@@ -39,10 +39,10 @@ function generate_part(name, part, boundary, callback) {
   var return_part = '--' + boundary + '\r\n';
   return_part += 'Content-Disposition: form-data; name="' + name + '"';
 
-  function append(data, filename) {
+  function append(data, filename, force_binary) {
 
     if (data) {
-      var binary = part.content_type.indexOf('text') == -1;
+      var binary = force_binary || part.content_type.indexOf('text') == -1;
       return_part += '; filename="' + encodeURIComponent(filename) + '"\r\n';
       if (binary) return_part += 'Content-Transfer-Encoding: binary\r\n';
       return_part += 'Content-Type: ' + part.content_type + '\r\n\r\n';
@@ -55,11 +55,11 @@ function generate_part(name, part, boundary, callback) {
   if ((part.file || part.buffer) && part.content_type) {
 
     var filename = part.filename ? part.filename : part.file ? basename(part.file) : name;
-    if (part.buffer) return append(part.buffer, filename);
+    if (part.buffer) return append(part.buffer, filename, true);
 
     readFile(part.file, function(err, data) {
       if (err) return callback(err);
-      append(data, filename);
+      append(data, filename, true);
     });
 
   } else {