Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Python 3.10 #169

Merged
merged 8 commits into from
Sep 20, 2022
Merged

Enable Python 3.10 #169

merged 8 commits into from
Sep 20, 2022

Conversation

tonyabracadabra
Copy link
Contributor

Motivation and Context

Why was this PR created?

How has this been tested?

What testing strategies have you used?

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change and added my name to the list of supporting contributions in the RELEASE.md file
  • Added tests to cover my changes
  • Assigned myself to the PR

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@oentaryorj oentaryorj changed the title chore: enable python 3.10 Enable Python 3.10 Sep 2, 2022
@oentaryorj
Copy link
Contributor

oentaryorj commented Sep 2, 2022

Thanks for your contribution @tonyabracadabra. Can we also make sure that the unit tests for 3.9 and 3.10 below have the "required" tag (and that they run successfully)?

@tonyabracadabra
Copy link
Contributor Author

Thanks for your contribution @tonyabracadabra. Can we also make sure that the unit tests for 3.9 and 3.10 below have the "required" tag (and that they run successfully)?

Sorry I am not sure how to make the Required tag available? Could u help me with that? I don't see any configuration differences between py3.9/3.10 vs the rest of the workflows. Thanks.

@oentaryorj
Copy link
Contributor

Hi @tonyabracadabra, we can address the "required tag" later, but would you be able to fix the issues with unit_tests_310 first please? Many thanks!

@tonyabracadabra
Copy link
Contributor Author

tonyabracadabra commented Sep 12, 2022

ok the test was not passed because of the coverage issue on line

arg_spec = inspect.getargvalues(inspect.currentframe())

I am not sure why it is not covered in testing, seems that getargvalues has been marked deprecated a while ago, I added a # pragma: no cover to make the coverage 100%, let me know if this is acceptable or not.

@oentaryorj
Copy link
Contributor

ok the test was not passed because of the coverage issue on line

arg_spec = inspect.getargvalues(inspect.currentframe())

I am not sure why it is not covered in testing, seems that getargvalues has been marked deprecated a while ago, I added a # pragma: no cover to make the coverage 100%, let me know if this is acceptable or not.

Yes, this is fine. If you can suggest an alternative to this deprecated function, though, it would be great! :)

@tonyabracadabra
Copy link
Contributor Author

tonyabracadabra commented Sep 13, 2022

ok the test was not passed because of the coverage issue on line

arg_spec = inspect.getargvalues(inspect.currentframe())

I am not sure why it is not covered in testing, seems that getargvalues has been marked deprecated a while ago, I added a # pragma: no cover to make the coverage 100%, let me know if this is acceptable or not.

Yes, this is fine. If you can suggest an alternative to this deprecated function, though, it would be great! :)

yea I've tried a couple approaches but they are either too complicated or not working as expected, so I would keep it as it is for now

@tonyabracadabra
Copy link
Contributor Author

Will we have a release soon for the recent support on python 3.9, 3.10? @oentaryorj

@tonyabracadabra
Copy link
Contributor Author

@GabrielAzevedoFerreiraQB Hey Gabriel could you help review it?

@oentaryorj
Copy link
Contributor

Will we have a release soon for the recent support on python 3.9, 3.10? @oentaryorj

We shall publish a new release once we have enough new features and/or bug fixes.

Copy link

@EvgeniiaVeselova EvgeniiaVeselova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EvgeniiaVeselova EvgeniiaVeselova merged commit 94b343a into mckinsey:develop Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants