-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Python 3.10 #169
Enable Python 3.10 #169
Conversation
Thanks for your contribution @tonyabracadabra. Can we also make sure that the unit tests for 3.9 and 3.10 below have the "required" tag (and that they run successfully)? |
Sorry I am not sure how to make the |
Hi @tonyabracadabra, we can address the "required tag" later, but would you be able to fix the issues with |
ok the test was not passed because of the coverage issue on line arg_spec = inspect.getargvalues(inspect.currentframe()) I am not sure why it is not covered in testing, seems that |
Yes, this is fine. If you can suggest an alternative to this deprecated function, though, it would be great! :) |
yea I've tried a couple approaches but they are either too complicated or not working as expected, so I would keep it as it is for now |
Will we have a release soon for the recent support on python 3.9, 3.10? @oentaryorj |
@GabrielAzevedoFerreiraQB Hey Gabriel could you help review it? |
We shall publish a new release once we have enough new features and/or bug fixes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation and Context
Why was this PR created?
How has this been tested?
What testing strategies have you used?
Checklist
RELEASE.md
fileNotice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.