[Bug] Fix display of marks in vm.Slider and vm.RangeSlider
#613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huong-li-nguyen
requested review from
Joseph-Perkins,
antonymilne and
maxschulz-COL
as code owners
huong-li-nguyen
commented
Aug 1, 2024
antonymilne
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Thank you for getting to the bottom of this and fixing it! Super clear dev example also - I love the containers with title which is much better than me getting confused about which row is which 😅 🤦
Just a couple of things about the tests but otherwise looks great.
vizro-core/tests/unit/vizro/models/_components/form/test_range_slider.py
Show resolved
Hide resolved
vizro-core/tests/unit/vizro/models/_components/form/test_range_slider.py
Outdated
Show resolved
Hide resolved
antonymilne
reviewed
Aug 1, 2024
vizro-core/tests/unit/vizro/models/_components/form/test_range_slider.py
Outdated
Show resolved
Hide resolved
antonymilne
reviewed
Aug 1, 2024
vizro-core/tests/unit/vizro/models/_components/form/test_range_slider.py
Outdated
Show resolved
Hide resolved
…_slider.py Thanks!! I like the first 👍 It prints out the types as well. Co-authored-by: Antony Milne <49395058+antonymilne@users.noreply.github.com>
… into bug/fix-slider-type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #612: Previously, our marks were converted to integers, leading to incorrect value displays. This, combined with an existing bug in Dash, caused the marks to be displayed incorrectly.
vm.Sliderandvm.RangeSlider@nadijagraca - I noticed that we previously had the typing
marks: Optional[Dict[float, str]], but it was changed in this PR: #230. Do you remember the reason for this change? I couldn't reproduce the original bug that the PR fixes, so I'm uncertain if reverting to the original typing will cause any issues. Could you also take a look? 🤔Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":