Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Drop Python 3.8 and add Python 3.13 support to Vizro #813

Merged
merged 26 commits into from
Oct 17, 2024

Conversation

antonymilne
Copy link
Contributor

@antonymilne antonymilne commented Oct 15, 2024

Description

  1. Drop Python 3.8 and add Python 3.13 for Vizro.
  2. Vizro-AI already had Python >= 3.9 so no need to drop anything there. It's not possible to add support for Python 3.13 yet due to Python 3.13 support huggingface/tokenizers#1639 and possibly others. @lingyielia please could you make a ticket to check this again in a few weeks/months and try to add Python 3.13 support?
  3. Add various new tools to ruff, especially pyupgrade which has helped to update our codebase to Python 3.9+.
    • The biggest difference this made is that PEP 585 means you no longer need to do the ugly from typing import List, Dict, ... - you can just use the builtin list etc. 🎉
    • Unfortunately we can't yet implement PEP 604 even with from __future__ import annotations because of pydantic. So we still need to do the ugly Union and Optional. When we drop Python 3.9 in a year's time this will go
  4. Bump lower bound of pydantic to 1.10.16 and changed lower bounds environment to use Python 3.9
  5. Bump our "standard" version for CI from Python 3.11 to 3.12
  6. There's no discrepancy for hatch run schema depending on Python version now so we can finally tidy up that job to not depend on a specific version.
  7. Speed up the vizro-core checks CI by not running pre-commit hooks after hatch run schema-check any more

TODO:

  • Update Github required jobs to add Python 3.9 lower bounds and 3.13
  • Update vizro-qa

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

@github-actions github-actions bot added the Vizro-AI 🤖 Issue/PR that addresses Vizro-AI package label Oct 15, 2024
antonymilne and others added 22 commits October 15, 2024 17:38
@antonymilne antonymilne changed the title Vizro to py38 and Vizro-AI to py39 [Feat] Drop Python 3.8 and add Python 3.13 support to Vizro Oct 16, 2024
@antonymilne antonymilne marked this pull request as ready for review October 16, 2024 16:13
@antonymilne antonymilne enabled auto-merge (squash) October 16, 2024 16:29
Copy link
Contributor

@huong-li-nguyen huong-li-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Just one minor question

Copy link
Contributor

@petar-qb petar-qb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good.

Copy link
Contributor

@maxschulz-COL maxschulz-COL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pyproject.toml Outdated Show resolved Hide resolved
vizro-core/hatch.toml Show resolved Hide resolved
@stichbury
Copy link
Contributor

LGTM, no docs observations

@antonymilne antonymilne merged commit f2a52c5 into main Oct 17, 2024
41 of 42 checks passed
@antonymilne antonymilne deleted the bump-python-py39 branch October 17, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Vizro-AI 🤖 Issue/PR that addresses Vizro-AI package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants