-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #11 - Onboard LED for pico_w not working #21
Conversation
Oh, and since I use JetBrains tools for most of my development I committed the .idea directory to ease the effort of other folks who use the same tools. Happy to nuke it and add to .gitignore if there's a reason you don't want it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - just a couple minor changes:
- Yes let's add
.idea/
to gitignore, I'd like to avoid bundling IDE settings for now (I use VScode and there's a lot of system-specific crap in there) - Minor boot print add - see inline comment
Looks good to merge after those changes are made.
if(cyw43_arch_init()) { | ||
uart_puts(UART_ID_CLI, timestamp()); | ||
uart_puts(UART_ID_CLI, "Failed to initialize CYW43 hardware.\r\n"); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add
else {
uart_puts(UART_ID_CLI, timestamp());
uart_puts(UART_ID_CLI, "Initialized onboard wireless module\r\n");
}
to print a success status message at boot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HAH! I thought I did. Must only be on my wifi branch. :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I am going to start using a pre-release branching strategy so that only release-up-revs go into main, so I'll merge this into v0.3-pre
This builds on the inclusion of the cygw43_arch_none library from the 0.2 release and makes the following changes:
Built using both Windows 11 and MacOS Sonoma, tested on an official Raspberry Pi Pico W.