Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health Estimate 31.4 show estimates of all tokens to everyone at all times #197

Closed
mxvs opened this issue Sep 3, 2023 · 3 comments
Closed
Labels
bug Something isn't working

Comments

@mxvs
Copy link

mxvs commented Sep 3, 2023

Describe the bug
Since upgrading to 31.4 Health Estimate has started showing estimates of all token to everyone, regardless of settings.

To Reproduce

  • Update to 31.4
  • Hover over any token, either as DM or as player
  • Get Health Estimate
  • Change behavior in settings
  • No change, health estimates are still being shown regardless of settings

Game Specifics (please complete the following information):
Foundry 11.308
Happens in both Pathfinder 2e 5.4.2 and D&D 5e 2.3.1

@mxvs mxvs added the bug Something isn't working label Sep 3, 2023
mclemente added a commit that referenced this issue Sep 3, 2023
Fix #195
Related to #197
@mclemente
Copy link
Owner

Which behavior setting did you change especifically? I couldn't reproduce this by changing "Always Show Estimates" and/or "Show Only on Combat".

There was a bug with the release that was fixed on 31.5, but I am not sure if this issue was fixed with the change.

@LukasPrism
Copy link

This is happening for me too after updating, I didn't change any settings.

I then went in and tried setting it to All and then back to NPCs only and it's still showing on player characters. dnd5e 2.3.1

@mxvs
Copy link
Author

mxvs commented Sep 4, 2023

Which behavior setting did you change especifically? I couldn't reproduce this by changing "Always Show Estimates" and/or "Show Only on Combat".

There was a bug with the release that was fixed on 31.5, but I am not sure if this issue was fixed with the change.

I can confirm that 31.5 fixes this isssue. It popped up after installing 31.4 without me changing any of the behavior settings. In any case its fixed now!

@mxvs mxvs closed this as completed Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants