-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Ruby2.7 support #71
Conversation
68b25af
to
12a4218
Compare
Hey, thanks for doing this! Did you want to leave your commits as-is or squash them? Just making sure before I merge. |
Also it looks like @aried3r got to this first so I merged in their PR — hope that's okay. I'm assuming that the other changes here have to do with upgrading to Ruby 2.7, though? Or are they to satisfy Rubocop? |
Sure 👍
Yeap, Ruby 2.7 shows some warnings right now. "warning: Using the last argument as keyword parameters is deprecated" for example. So, my changes are around suppressing that deprications and warnings.
I'll do it. Just want to fix couple of warnings before that. |
12a4218
to
ecdb554
Compare
Hey, just checking here. Was there any more work you wanted to do on this? |
@mcmire thank you for your "ping" :) I'll check and back with results tomorrow. |
@mcmire So, I did fix what I can. Other warnings are coming from the "rspec-expectations" and the "attr_extras" gems. |
Okay! Thanks so much for doing this! |
This PR suppress some Ruby2.7 warnings.