Skip to content

WIP: Ruby2.7 support #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2020
Merged

WIP: Ruby2.7 support #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c88ee29
Prepare for Ruby 2.7
numbata Feb 10, 2020
0b7374f
Get rid of "instance variable not initialized" warnings
numbata Feb 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/super_diff/operational_sequencers/hash.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ def unary_operations_using_variant_of_patience_algorithm
start_index.upto(eks.size - 1) do |ei2|
ek = eks[ei2]
ev, av2 = expected[ek], actual[ek]
ai2 = aks.index(ek)

if actual.include?(ek) && ev == av2
# If the key in 'expected' we've landed on happens to be a
Expand Down
2 changes: 1 addition & 1 deletion lib/super_diff/rspec/augmented_matcher.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def build_failure_message(negated:)

def matcher_text_builder
@_matcher_text_builder ||=
matcher_text_builder_class.new(matcher_text_builder_args)
matcher_text_builder_class.new(**matcher_text_builder_args)
end

def matcher_text_builder_class
Expand Down
2 changes: 1 addition & 1 deletion lib/super_diff/rspec/matcher_text_builders/match.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module RSpec
module MatcherTextBuilders
class Match < Base
def initialize(expected_captures:, **rest)
super(rest)
super(**rest)
@expected_captures = expected_captures
end

Expand Down
2 changes: 1 addition & 1 deletion lib/super_diff/rspec/matcher_text_builders/respond_to.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ def initialize(
unlimited_arguments:,
**rest
)
super(rest)
super(**rest)
@expected_arity = expected_arity
@arbitrary_keywords = arbitrary_keywords
@expected_keywords = expected_keywords
Expand Down
2 changes: 1 addition & 1 deletion lib/super_diff/rspec/operational_sequencers/collection_containing_exactly.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ def self.applies_to?(expected, actual)
actual.is_a?(::Array)
end

def initialize(actual:, **rest)
def initialize(actual:, **)
super
populate_pairings_maximizer_in_expected_with(actual)
end
Expand Down