Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List in-progress forms in descending order of latest to earliest timestamps #65

Merged
merged 8 commits into from
Oct 27, 2023

Conversation

jtquach1
Copy link

@jtquach1 jtquach1 commented Oct 9, 2023

Describe your changes

Please include a summary of the changes and the related issue/task. Please also include relevant motivation and context. List any dependencies that are required for this change, including links to other pull requests/branches in other repositories if applicable.

Sorted in-progress selectable QuestionnaireForms by the QuestionnaireForm.authored timestamp from latest to earliest.

Related PRs and branches (but not required to checkout to for reviewing this PR):

Before

image

After

image

Issue ticket number and Jira link

Please include the Jira Ticket Number and Link for this issue/task.

REMS-530

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@jtquach1 jtquach1 force-pushed the descending-order-forms branch from 61c7b56 to 8b585bd Compare October 18, 2023 19:34
@jtquach1
Copy link
Author

After rebasing off origin/dev:
image

@jtquach1 jtquach1 force-pushed the descending-order-forms branch from 44c9aa4 to 37545a8 Compare October 23, 2023 16:11
… server instead of sorting them in the frontend display
@jtquach1
Copy link
Author

After reverting change to frontend display (in modal) and changing search parameters sent to test-ehr:
image

@jtquach1 jtquach1 force-pushed the descending-order-forms branch from a760ace to f25ca1b Compare October 23, 2023 20:13
@jtquach1 jtquach1 force-pushed the descending-order-forms branch from f25ca1b to de5038b Compare October 23, 2023 20:18
@jtquach1 jtquach1 marked this pull request as ready for review October 24, 2023 18:53
@jtquach1 jtquach1 mentioned this pull request Oct 24, 2023
4 tasks
@jtquach1 jtquach1 merged commit 0425bf4 into dev Oct 27, 2023
@jtquach1 jtquach1 deleted the descending-order-forms branch October 27, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants