fix: do not show warnings when workers >= 10

lib/progressTracker.js

@@ -18,6 +18,7 @@ const defaults = {
  renderResultsTable: true,
  renderLatencyTable: false
 }
+let spinner
 
 function track (instance, opts) {
  if (!instance) {
@@ -34,7 +35,6 @@ function track (instance, opts) {
  let durationProgressBar
  let amountProgressBar
  let addedListeners = false
- let spinner
 
  instance.on('start', () => {
  if (opts.renderProgressBar && isMainThread) {
@@ -79,7 +79,9 @@ function track (instance, opts) {
  })
 
  function showSpinner () {
- spinner = ora('running...')
+ if (!spinner) {
+ spinner = ora('running...')
+ }
  spinner.start()
  }
 

package.json

@@ -42,6 +42,7 @@
  "busboy": "^0.3.1",
  "pre-commit": "^1.1.2",
  "proxyquire": "^2.1.3",
+ "sinon": "^9.2.4",
  "split2": "^3.2.2",
  "standard": "^16.0.3",
  "tap": "^14.10.8"

test/progressTracker.test.stub.js → test/progressTracker.test.js

@@ -2,8 +2,12 @@
 
 const helper = require('./helper')
 const test = require('tap').test
+const { defaultMaxListeners } = require('events')
+const sinon = require('sinon')
 const progressTracker = require('../lib/progressTracker')
 const autocannon = require('../autocannon')
+const { hasWorkerSupport } = require('../lib/util')
+
 test('progress tracker should throw if no instance is provided', t => {
  t.plan(1)
  try {
@@ -94,3 +98,24 @@ test('should log resets', t => {
  })
  t.pass()
 })
+
+test(`should not emit warnings when using >= ${defaultMaxListeners} workers`, { skip: !hasWorkerSupport }, t => {
+ const server = helper.startServer()
+
+ const instance = autocannon({
+ url: `http://localhost:${server.address().port}`,
+ workers: defaultMaxListeners,
+ duration: 1
+ })
+
+ setTimeout(() => {
+ instance.stop()
+ t.false(emitWarningSpy.called)
+ emitWarningSpy.restore()
+ t.end()
+ }, 2000)
+
+ const emitWarningSpy = sinon.spy(process, 'emitWarning')
+
+ autocannon.track(instance)
+})