Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a bailout option #21

Closed
GlenTiki opened this issue Jun 24, 2016 · 2 comments
Closed

Add a bailout option #21

GlenTiki opened this issue Jun 24, 2016 · 2 comments

Comments

@GlenTiki
Copy link
Collaborator

If running a test against a server which dies, maybe you want your test to stop?

In this case, it might be useful to allow a user to specify a threshold of errors within a specific timeframe to cause a bailout. This would surely damage perf though A better way of managing this is to just exit after the error threshold is hit (not needing an error timeframe).

Examples:

Say you have a server you are benchmarking for half an hour. The server dies after 10 minutes. To detect this, we could either:
Detect if there was 1000 errors from the server within the last second OR we could detect if there was 10000 errors overall.

@GlenTiki
Copy link
Collaborator Author

Or maybe we could have a timeframe number, and just set an interval to clear the error count during that timeframe, and then the we just check against the number of errors, which is cleared per timeframe iteration. That might not damage perf like tracking the amount of errors since an error which is within the timeframe

@mcollina
Copy link
Owner

👍 send a PR.

mcollina added a commit that referenced this issue Jun 25, 2016
Fixed #21: added a bailout option.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants