Removes the binary dependency #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlenTiki
reviewed
Jan 25, 2018
There was a problem hiding this comment.
this lgtm, but I'll take a look at appveyor before merging
Appveyor is broken due to the buffer changes you've made not being backported to the older versions of v4/5. I've slacked you an alternative appveyor file to work on for getting that ci green again. we should still support 4 until its EOL at end of March/April, right?
GlenTiki
reviewed
Jan 25, 2018
.travis.yml
Outdated
| @@ -4,6 +4,8 @@ node_js: | |||
| - "4" | |||
| - "6" | |||
| - "7" | |||
| - "8" | |||
| - "9" | |||
| env: | |||
| - CC=gcc-4.8 CXX=g++-4.8 | |||
There was a problem hiding this comment.
We should actually be able to remove these build tools, right?
|
This should be ready to land. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled, this switches from native-hdr-histogram to hdr-histogram-js.
In my tests, the throughput is about the same, if not slightly higher.
It solves all the problems downloading binary components.