Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use headers from requests if any #364

Merged
merged 4 commits into from
May 6, 2021

Conversation

RafaelGSS
Copy link
Contributor

This PR aims to fix a behavior expected in https://github.com/rafaelGSS/autobench#config-file by specifying headers inside opts.requests.

Currently, the lib isn't using request[index].headers in the requests, this PR should solve it.

Copy link
Owner

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RafaelGSS
Copy link
Contributor Author

I removed a duplicated test made by me. Sorry.

@mcollina mcollina merged commit bee825f into mcollina:master May 6, 2021
@RafaelGSS
Copy link
Contributor Author

@mcollina Could you land a minor with this PR? Or there are any plans to release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants