fix(report): align printResult to output the correct total requests #380
Conversation
|
I'm not sure this is the correct fix, as the additional requests are done. This PR is just hiding them. |
…use result.requests.sent instead of opts.amount Closes mcollina#228
correct @mcollina . In the scenario I am fixing, all the requests were sent to the tested server, only the output was wrong: 10 requests instead of 20 requests. I verified it with my local server - it receives all 20 requests. |
test/printResult.test.js
Outdated
| } | ||
| } | ||
| const opts = { | ||
| outputStream: { |
There was a problem hiding this comment.
in the test, I am simulating the bug in method printResult, which gets two parameters as input: result and opts.
so to gets the same behaviour while executing node autocannon..., I took the two objects value while debugging and used them as input for simulating the bug in the test.
There was a problem hiding this comment.
I don't think this entire opts object is needed, could you remove the properties that are not used?
There was a problem hiding this comment.
right. I removed the non-mandatory input. it seems throughput is mandatory with all its pX properties.
…removing input which is not mandatory for the test Closes mcollina#228
Closes #228