Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced 'clone' library with 'lodash.clonedeep' #400

Merged
merged 4 commits into from
Oct 15, 2021
Merged

Replaced 'clone' library with 'lodash.clonedeep' #400

merged 4 commits into from
Oct 15, 2021

Conversation

radomird
Copy link
Contributor

Replaced the clone library with lodash.clonedeep. Main reason is this issue on the clone library.

Closes #391

@radomird radomird changed the title Replaced 'clone' library with 'lodash.clonedeep' #391 Replaced 'clone' library with 'lodash.clonedeep' Oct 14, 2021
simoneb
simoneb reviewed Oct 14, 2021
View reviewed changes
Copy link
Contributor

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. So this solution works without using the v8 serialization APIs that Matteo suggested, right? Let's make sure the test you wrote consistently fail without the production code change.

@radomird
Copy link
Contributor Author

I've updated the test and the issue can be consistently reproduced with production code.

@mcollina mcollina merged commit 11192ce into mcollina:master Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simoneb simoneb simoneb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to load PFX certificate with tlsOptions + workers
3 participants
@radomird @simoneb @mcollina