assume onPort if -- node is set

[karankraina]

Adds support for #180

@mcollina Please review when you have some time.

[mcollina]

I think we can just remove --onPort.

Remember to adjust the docs.

[karankraina]

Thanks for your review @mcollina . Also, if we remove onPort flag, I think the check should not striclty be restricted to -- node. We should assume on Port if -- <any-script> is provided. Your thoughts ?

[mcollina]

Ah, that's true. Then, this is good. Can you just update the docs?

[karankraina]

Sure, updating.

[karankraina]

@mcollina Does it look okay to you?

[mcollina]

lgtm

[karankraina]

@mcollina checks on node v14 on mac and node v20 on windows are failing. Can see other merges with these fails too. Any known issues ?

[mcollina]

Drop node 14 and v16 support, I'll bump
the major.

windows is likely flaky.

[karankraina]

Should I add v22 ?

[mcollina]

yes please

[karankraina]

Done but windows still not happy. I think we need another issue to address that. And if this looks good, can we merge it?

[karankraina]

@mcollina

[mcollina]

I'll look into the windows tests asap.

[mcollina]

windows tests are fixed, can you rebase?

[mcollina]

lgtm