Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh dependencies and list of supported Node.js versions #219

Merged
merged 2 commits into from
May 6, 2024

Conversation

kibertoad
Copy link
Contributor

  • Updates runtime dependencies to latest versions
  • Adds recent Node.js runtimes to CI
  • Updates TypeScript and related dependencies
  • Bumps expected engine version to the minimum one included in CI

package.json Outdated
@@ -30,7 +30,7 @@
},
"author": "Matteo Collina <hello@matteocollina.com>",
"engines": {
"node": ">=10"
"node": ">=14"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Node 10 and 12 is not included in CI, it's not really possible to guarantee that they are still supported.

@@ -30,7 +30,7 @@
},
"author": "Matteo Collina <hello@matteocollina.com>",
"engines": {
"node": ">=10"
"node": ">=16"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two reasons for this change:

  • CI already was not executed on 10 and 12 before this change
  • Newer TypeScript linter doesn't work on Node < 16. If for whatever reason it is important to preserve compatibility with Node 14, I can separate CI runs for linting and tests, but 14 has been EOL for a while anyway.

@kibertoad kibertoad changed the title Refresh dependencies Refresh dependencies and list of supported Node.js versions May 3, 2024
Copy link
Owner

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

This is ok. However I would need a bunch of PRs to update/refresh this everywhere. Could you help with that as well?

@kibertoad
Copy link
Contributor Author

@mcollina Of course! Can you give a list of repos?

@mcollina
Copy link
Owner

mcollina commented May 6, 2024

mqemitter/README.md

Lines 17 to 22 in 061c68a

- [mqemitter-redis]: Redis-powered mqemitter
- [mqemitter-mongodb]: Mongodb based mqemitter
- [mqemitter-child-process]: Share the same mqemitter between a hierarchy of child processes
- [mqemitter-cs]: Expose a MQEmitter via a simple client/server protocol
- [mqemitter-p2p]: A P2P implementation of MQEmitter, based on HyperEmitter and a Merkle DAG
- [mqemitter-aerospike]: Aerospike mqemitter
ideally all, but -redis and -mongodb are 100% needed.

@mcollina mcollina merged commit bf559a3 into mcollina:master May 6, 2024
5 checks passed
@kibertoad kibertoad deleted the chore/dependencies-05-03 branch May 6, 2024 13:14
@kibertoad
Copy link
Contributor Author

Will go over them this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants