Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for map that holds more than 65535 keys #54

Closed
kyriosli opened this issue Mar 1, 2017 · 1 comment
Closed

support for map that holds more than 65535 keys #54

kyriosli opened this issue Mar 1, 2017 · 1 comment

Comments

@kyriosli
Copy link

kyriosli commented Mar 1, 2017

When encoding an key-value map, the encoder treats keys that more than 16 as just less than 65536, which may cause problem when serializing objects with large amount of keys, as shown here. I might issue a pull request as soon as I finished the full compatibility tests if you shall not be available for a fix, but plz be kind enough to push a new release on npm after then, ^_^
@mcollina
Copy link
Owner

mcollina commented Mar 1, 2017

Please send a PR :). I'm low on bandwidth atm.

@guylando guylando mentioned this issue May 8, 2018
Closed
imnotjames added a commit to imnotjames/msgpack5 that referenced this issue May 16, 2018
@imnotjames
support for map32
2dc73e4 
This adds support and test for map32 - a map with items of up to
length 2^32-1

A few tests were added to check that the support is working as
expected.

Fixes mcollina#54
@imnotjames imnotjames mentioned this issue May 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcollina @kyriosli