use bl@5's isBufferList to detect buffer list #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
requested changes
Apr 11, 2022
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "msgpack5", | |||
| "version": "5.3.2", | |||
| "version": "6.0.0", | |||
There was a problem hiding this comment.
please revert this. I'll bump it when I release.
mcollina
requested changes
Apr 11, 2022
package.json
Outdated
| }, | ||
| "standard": { | ||
| "ignore": [ | ||
| "dist/" | ||
| ] | ||
| }, | ||
| "peerDependencies": { | ||
| "bl": "^5.0.0" |
There was a problem hiding this comment.
Please bring this back as a dependency. peerDependencies create more problems than the ones they solve.
`instanceof` doesn't work when using different instances of the BufferList class, for example when different versions of buffer list are used. This commit upgrades to bl@5 which adds `isBufferList` which should work across versions of `bl`. fixes mcollina#104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instanceofdoesn't work when using different instances of theBufferList class, for example when different versions of buffer list are
used.
This commit upgrades to bl@5 which adds
isBufferListwhich should workacross versions of
bl.I also moved
blto a peer dependency so it's easier for consumers tomatch the bl version, and bumped the version to 6.0.0 because npm
doesn't install peer dependencies by default which could break consumers
without a bl dependency.
fixes #104