Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to readable-stream@3 #19

Merged
merged 3 commits into from
Aug 12, 2018
Merged

Updated to readable-stream@3 #19

merged 3 commits into from
Aug 12, 2018

Conversation

mcollina
Copy link
Owner

No description provided.

@mcollina mcollina merged commit be6dad6 into master Aug 12, 2018
@mcollina mcollina deleted the next branch August 12, 2018 22:09
@gajus
Copy link

gajus commented Aug 13, 2018

Please document in the release notes whats the reason this is a breaking change.

I am assuming you've dropped Node <6 support?

@mcollina
Copy link
Owner Author

It is documented. Upgraded to readable-stream@3, which is a breaking change on it: https://github.com/nodejs/readable-stream#version-3xx.

@gajus
Copy link

gajus commented Aug 13, 2018

It is not documented in the split2 module.

@mcollina
Copy link
Owner Author

There is a tagged release, listing the update to readable-stream@3 as the only change: https://github.com/mcollina/split2/releases/tag/v3.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants